From the course: Programming Foundations: Conducting Code Reviews

Unlock the full course today

Join today to access over 22,600 courses taught by industry experts or purchase this course individually.

Solution: Give a code review

Solution: Give a code review

From the course: Programming Foundations: Conducting Code Reviews

Start my 1-month free trial

Solution: Give a code review

“

(bright music) - [Instructor] There are lots of different code review comments you could leave on a given PR, but in this solution, we'll walk through a few potential comments. Starting with the Java code base, let's click Pull requests and navigate to the Clear Calculator Values PR. Here, we can read through the author's purpose as well as what they changed and how we can test it. As a user, I would like to have a way to clear my calculator. So what did the developer do? They added clear calculator functionality to the calculator class and then integrated it into the main class. To test it, we need to run the application and clear the calculator. Now that we understand what the changes should be, let's clone the repo and run the tests in code locally. I'll open it in desktop, which will open GitHub desktop. This allows us to easily clone it. We'll switch over to the PR branch, clear calculator values, that's it. Then we'll open up this PR code in IntelliJ. Before we run the…

Contents