From the course: Programming Foundations: Conducting Code Reviews

Unlock the full course today

Join today to access over 22,600 courses taught by industry experts or purchase this course individually.

Respond to code reviews comments

Respond to code reviews comments

From the course: Programming Foundations: Conducting Code Reviews

Start my 1-month free trial

Respond to code reviews comments

“

- [Instructor] Once you have a few comments on your pull request, it's time to read through them and respond appropriately. You should respond to every review comment, even if it's a simple, "Done." If you disagree with the review comment, you can explain why you made certain design decisions or separated various functionalities. Let's take a look at a few examples. This is our ad exponentiation PR and we have a few comments. This code review comment is about the design. In this case, it says, "Can we state "the new operation first?" In our code changes, we put the caret operation last. This reviewer wants us to put that caret operation first. In the story or piece of work we picked up, it might've stated the order for what operations should be listed first. If in the requirements for the work, it stated the exponentiation symbol should be last, you could leave a comment linking to the documentation stating the spec for the feature. If not, and you agree with the comment, you could…

Contents